Add Bijectors integration tests #353
Merged
+142
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
willtebbutt
reviewed
Nov 7, 2024
There was a problem hiding this comment.
This is great, thank you for opening this.
Regarding the failing test: it's one that we know about already, and is related to this rather annoying upstream problem. We need some way of indicating that this is a problem. I propose the following:
- exclude the offending example from the main test suite
- call
build_ruleon the test case, which should be enough to trigger the error. Put this call inside a@test_brokenthing, so that when we eventually fix the problem we find out about it.
Does this sound sensible to you?
|
I put in the following, does this do what you wanted? TestCase(
function (x)
layer = Bijectors.PlanarLayer(x[1:2], x[3:4], x[5:5])
flow = Bijectors.transformed(
Bijectors.MvNormal(zeros(2), LinearAlgebra.I),
layer,
)
x = x[6:7]
return Bijectors.logpdf(flow.dist, x) -
Bijectors.logabsdetjac(flow.transform, x)
end,
randn(Xoshiro(23), 7);
name = "PlanarLayer7",
# TODO(mhauru) Broken on v1.11 due to
# https://github.com/compintell/Mooncake.jl/issues/319
broken=(VERSION >= v"1.11"),
), if case.broken
@test_broken begin
test_rule(Xoshiro(123456), case.func, case.arg; is_primitive=false)
true
end
else
test_rule(Xoshiro(123456), case.func, case.arg; is_primitive=false)
end |
willtebbutt
approved these changes
Nov 7, 2024
|
I'll merge when CI has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied over from EnzymeAD/Enzyme.jl#2037.
Closes #348